[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: BUG: Icon misalignment

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-08-21 19:13:08 CEST

Simon Large wrote:
> Stefan Küng wrote:
>> Aaron D. Marasco wrote:
>>> I have spotted a bug in the latest release version that I don't see
>>> mentioned in the latest changes.txt etc. I have verified this a few
>>> times on Windows XP.
>>>
>>> To replicate:
>>> 1. Hidden folders in Explorer must be visible (so you see .svn/)
>>> 2. Erase all the files in the folder (except .svn of course)
>>> 3. "SVN Update" to get the files back.
>>>
>>> Result:
>>> .svn folder gets checkmark icon overlay.
>>> First file in directory has no overlay.
>>> Second file and remaining files have checkmark overlay.
>>>
>>> To fix:
>>> F5 refreshes display and all is good.
>>
>> That's not really a bug but designed that way. You see, while you're
>> updating, the working copy becomes locked (locked in the sense that
>> the update or any other operation prevents other Subversion operations
>> from working). If that happens and the explorer asks for the overlays,
>> TSVN simply checks for the existence of the .svn folder. If that
>> folder is present, it returns 'normal' so the explorer will show the
>> green overlay. It does this because if the working copy is locked, it
>> can't get the status at all, so *everything* is assumed versioned.
>>
>> Once the update has finished, the lock is removed and other Subversion
>> operations will succeed again (like fetching the status). Then a
>> refresh in the explorer will show the correct overlays again.
>
> I see this all the time on my work PC. The problem is not that the
> overlay is incorrect, it's that it is shown on the .svn folder.
> Typically I change a file, and in explorer the file is shown as
> unmodified and the .svn folder is shown as modified. I think this may be
> due to a race condition within Explorer itself. Is that correct?

Yes, it's a race condition in the explorer. Debugging shows clearly that
we pass the correct overlay information but the explorer then draw the
overlay on the wrong item.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon Aug 21 19:13:33 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.