[Patch] TSVN stumbling over CrashRpt.Dll

Hi devs,

In the following independant scenarios TortoiseProc crashes when starting.

Scenario 1:
Place versions of the files CrashRpt.dll and zlib.dll which are not
compatible to TSVN into a directory and add this directory to %path%. Any
call to TortoiseProc will crash the application.

Scenario 2:
Place versions of the files CrashRpt.dll and zlib.dll which are not
compatible to TSVN into any Subversion controlled directory and try to "SVN
Add" them.

Incompatible versions of the two files can be found here:
http://www.codeproject.com/debug/crash_report/crashrpt_demo.zip

In both cases TSVN crashes because the constructor of CCrashReport
successfully loads CrashRpt.dll ("LoadLibrary") but then fails to find the
function InstallEx ("GetProcAddress")

A simple patch is attached. This prevents TSVN from crashing on startup but
crash reporting is obviously not available then.

I would like to commit this and merge it into the 1.4.x branch. Stefan, is
that ok with you or do want a superior solution? Idea: We could pass a
full absolute path to "LoadLibrary" so that TSVN gets the correct version.
I'm surprised to not find CrashRpt.dll in the bin directory of the TSVN
installation. Where is it?

Tobias

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org