[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Avoid incorrect hint for "Stop on copy/rename"

From: Kazutoshi Satoda <k_satoda_at_f2.dion.ne.jp>
Date: 2006-08-04 23:29:43 CEST

Hi.

The hint for "Stop on copy/rename" implemented in r7065 appears when
fetching log is stopped at revision 1. This is incorrect.
I'm using 1.4.0, Build 7149 - 32 Bit -dev, 2006/07/27 21:41:50.

The attached patch will avoid this incorrect hint. I'm sorry that
I can't build TSVN by myself. So please look and verify the changes
before committing.

--
k_satoda

Index: src/TortoiseProc/LogDlg.cpp
===================================================================
--- src/TortoiseProc/LogDlg.cpp (revision 7189)
+++ src/TortoiseProc/LogDlg.cpp (working copy)
@@ -728,14 +728,13 @@
                 m_pegrev = m_startrev;
         size_t startcount = m_logEntries.size();
         m_lowestRev = -1;
+ m_bStrictStopped = false;
         if (!ReceiveLog(CTSVNPathList(m_path), m_pegrev, m_startrev, m_endrev, m_limit, true, m_bStrict))
         {
                 CMessageBox::Show(m_hWnd, GetLastErrorMessage(), _T("TortoiseSVN"), MB_ICONERROR);
         }
- if (((m_bStrict && m_limit)&&((startcount + m_limit)>m_logEntries.size()))||((m_bStrict && (m_limit==0))&&(m_endrev<m_lowestRev)))
+ if (m_bStrict && (m_lowestRev>1) && ((m_limit>0) ? ((startcount + m_limit)>m_logEntries.size()) : (m_endrev<m_lowestRev)))
                 m_bStrictStopped = true;
- else
- m_bStrictStopped = false;
         m_LogList.SetItemCountEx(m_bStrictStopped ? m_arShownList.GetCount()+1 : m_arShownList.GetCount());
 
         m_timFrom = (__time64_t(m_tFrom));

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Aug 4 23:30:59 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.