Re: "Show log..."-button not working in the update dialog...

Carsten Johnsen wrote:
> Hi dev@
>
> I'm using latest nightly: TortoiseSVN 1.4.0, Build 7059 - 32 Bit -dev
>
> Today when I did an update, and the update finished, the "Show
> Log..."-button appears. But nothing happens when I click the button.
>
> This behaviour does not seem to be affected by whether or not there is
> actually something to update.
>
>
> Stefan: I can see you made some changes to SVNProgressDlg.cpp yesterday
> (r7057), so I guess there could be a connection.
>
> Somehow it seems (it != m_UpdateStartRevMap.end()) (line 1109)
> never evaluates to true and so the log never opens.
>
>
>>From what I understand from your log message, you don't what to show the
> "Show log..."-button if there was nothing to update. Previously the
> "Show log..."-button would show the last revision if there was nothing
> to update, and this is a feature I have been using a lot, just to remind
> myself what the last commit was, even when there was nothing to update.
> - So if I understand your log-message correctly, I hope you will
> reconsider to reintroduce this behaviour.

Changed in revision 7064.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org