Re: Calculations for stat graph?

Carsten Johnsen wrote:

> I was looking at the stat graph today and something looks wrong to me...
>
> The first thing I did was to upgrade to latest nightly: TortoiseSVN 1.4.0, Build 7023 - 32 Bit -dev
> This didn't remove the problem, and I couldn't find anything in flyspray.
>
> The problem:
> When showing the the statistics graph by date, it looks like the new summation with the new dynamic increment makes a wrong calculation.
>
> I've used the TortoiseSVN repo for the example, so it should be easily reproduceable.
>
> Rightclick TSVN trunk and chose "show log..."
> Click "Show all" button
> Click "Statistics" button
> Select "Commits by date" view (see attached stats.png)
> The graph looks a bit funny. It looks like the has been very few commits in Q4 of any year.
> I then tried looking at the log, and it doesn't show this behaviour.
> I've added the commits from then points in the graph, and I also counted the number of commits in the log dialog.
>
> Graph Log Delta
> Q1/05 637 637 0
> Q2/05 1048 830 +218
> Q3/05 983 681 +302
> Q4/05 245 765 -520
> Q1/06 768 768 0
> Sum 3681 3681 0
>
> It looks like Q1/05 and Q1/06 are correct, but the three other quarters are wrong (this looks to be the case no matter what year I focus on). When looking at a full year the value looks to be OK.
>
> I've done a bit of digging, and I found out that when looking at the log from 2005-04-01 and 1048 commits ahead (equals Q2/05 in the graph) this number is reached at 2005-07-31 sĺ the graph counts in an extra month (M4/05-M7/05)
>>From 2005-08-01 and 983 commits ahead shows 2005-11-30, so this is shifted one month, and counts in one extra month as well (M8/05-M11/05).
> And of course the 245 commits shown in the graph for Q4/05 only covers M12/05.
>
> Unfortunately I'm no expert at C++ (I normally deal with Delphi), so I'm no good at correcting this myself, but I tried to make the report as accurate as possible.
>
> If you need any more information please let me know, and I will be happy to help.
> This is not a major issue for me, I'm just sending this mail to help get rid of small glitches, in this otherwise fantastic software. - Thanks for an excellent job...

Thanks for the detailed report.
Fixed in revision 7026.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org