[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue with file name case on adding files

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-06-23 19:55:05 CEST

Will Wilson wrote:
> Me again,
> I've just been going through the code
> (CSVNStatusListCtrl::BuildStatistics) that does the case fix for file
> names. On looking at the add dialog code I realize that this same
> algorithm is run as per the commit dialog. So to clarify; this works as
> expected on folders (file name case is converted), just not when you
> select the file(s) directly (file name case is not converted & you can
> continue the add). I hope this helps narrow down the cause...

I've noticed that too (well, *after* opening an issue for it).
The reason we don't fix those when you select the files directly for add
is that by selecting something explicitly, we must assume that this is
really what the user wanted to do (hey, if you really, absolutely want
to shoot yourself in the foot, we don't have the right to stop you).

Also, you have to understand here that there's always some edge cases
where TSVN can't fix this problem. That's why you should install a
pre-commit hook script to not let such things get committed in the first

> Apologies for not volunteering to fix this myself, I just haven't had a
> chance to set up the build environment yet. I know... excuses,
> excuses... ;)
> Cheers,
> Will.
> PS. Any views on the tsvn:enforceextcase suggestion in my previous post?
> I might try implementing it myself but would like some feedback first!

I have to think about that a little longer. My first impression is that
we shouldn't do it (but as I said: let me think some more about it).
Even though I'm all in favor of helping users to do the right thing and
correct whatever went wrong, I already know of two edge cases where we
simply can't correct this. And the problems that occur if you set the
property and *then* TSVN tries to 'fix' the case of filenames...

Ok, that's all for today - preparing to watch the game Switzerland
against South Korea. It doesn't happen too often that Switzerland is
even part of these big games :)


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Jun 23 19:55:21 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.