Re: Questionable use of global ignore for files in unversioned folders

Kazutoshi Satoda wrote:
> I(and my colleague) found that the global ignore setting doesn't work
> as expected.
>
> For example, even if I set Thumbs.db into global ignore pattern, add
> dialog for an unversioned folder shows Thumbs.db in that folder, and
> it is checked by default. I think these files also should be ignored.
> The svn command line client does ignore these files.
>
> I have looked into the source code, and found the function
> SVNConfig::MatchIgnorePattern(). This function use a file path as
> the argument for svn_cstring_match_glob_list(). I think this is
> questionable. Isn't this API only for file name(without directory part)?
> If it is, attached patch will work. The patch is based on grep-ing
> for "MatchIgnorePattern".

Thanks for the patch!
Committed in revision 6673.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org