Hi Simon,
On Sunday 14 May 2006 00:46, Simon Large wrote:
> I have just made a minor clarification to the needs-lock balloon
> message. Feel free to revert or change again if you don't like it.
looks good.
> While trying that out I noticed that if you apply the svn:needs-lock
> property directly in the Get Lock dialog, the warning triangle
> disappears and you can get the lock. As I did not commit the change, the
> needs-lock property is not in the repository so the strict locking
> protection is not really there. I'm not sure if there is anything you
> can do to detect this corner case :-(
Good point!
Instead of checking if the property svn:needs-lock is set in the working
copy we need to check if it is set in BASE or maybe even in HEAD.
IMHO, it is enough to check in BASE which is a local operation. Checking in
HEAD would require connecting to the repository. I don't like connecting to
the repository when opening the dialog "only" to be able to display the
warning in the rare case that the property is not set correctly.
Any other opinions?
Do we need to rephrase the warning message to take this change into account?
It currently reads:
"Getting a lock for files without the 'svn:needs-lock' property will
<b>not</b> prevent others from editing them in their working copies.\nTo
enable strict locking please add the 'svn:needs-lock' property to all files
that need locking, and commit those files.\nEach file will have the
file-system read-only flag set, and getting a lock will make the file
writable.\nNote that other users will need to update their working copies
before they see the files as read-only."
It clearly states that the property needs to be committed. I think that is
enough.
Stefan, could you please have a look at the patch. Is there no easier way of
implementing it?
Tobias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun May 14 21:06:48 2006