Re: Issue#212 crashing TSVN when dropping multiple items

Tobias Schäfer wrote:
> Hi Stefan,
>
> I recently wanted to try the dropping of directories in the commit dialog, see
> #212.
>
> I have noticed that TSVN crashes almost every time I drop more than one
> directory at a time. Dropping a single directory or file seems to work
> reliably.
> The reason for the crash seems to be that CLogPromptDlg::OnFileDropped gets
> called for each dropped item asychronicaly and each in turn calling
> CLogPromptDlg::Refresh() which starts the StatusThread. I guess that this
> causes a race condition.
>
> To reproduce:
> - call "Commit" on the "d:\Development\SVN\TortoiseSVN\src" directory
> - In the directory "d:\Development\SVN\TortoiseSVN" select "bin" and "contrib"
> and drag and drop them on the commit dialog.
>
> TSVN crashes almost every time. I'm currently using the nightly build 6275.
>
> Anything you can do to fix it? I'm kind of lost ;-)

I'll have a look.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org