Re: Small glitches in the new "Edit Properties" Dialog, issue #166

On 3/13/06, Tobias Schäfer <tobiasschaefer@gmx.de> wrote:

> I think it is easier if you have a look at the following points yourself.

I'll do.

> They all concern the "Edit Properties" and "Edit Property" dialogs of issue
> #166
>
> - In the "Edit Properties" dialog, please change the first tab-position to the
> list control. It looks a bit strange if the file name is highlighted when the
> dialog is opened.

I think setting the focus on the list control would be better than
changing the tab order.

> - If you set the cursor to a property with the keyboard the add/remove buttons
> are not activated/named correctly because OnNMClick... is not called when
> using the keyboard

What message would you recommend to use here?

> - Selecting a property and then deselecting the property makes the button on
> the right side get named "Add..." (ok). If you press "Add..." the value of
> the previous selected item is used for the new property. It should actually
> be empty.
> - Setting the property name of a property to something which is not in the
> selection list, e.g. "foo"; closing the "Edit Properties" Dialog and opening
> it again only sets the property value correctly. The property name is empty
> (error) but should be "foo".
> - It would be nice if a double click on a property would open the edit dialog
> of that property.

Will do.

> - Setting a property recursively is only possible on directories. Please
> deactivate the checkbox for files where it doesn't make sense. Users might be
> confused.

Hmmm - doesn't it already work like this? I'll check as soon as I get home.
But of course, if you select more than one entry to edit the props
for, it doesn't check if *all* items are files but assumes that it may
have a folder in the list.

> - Removing a property on a file pops up a message box which asks if I would
> like to remove the property recursively. Again, this only makes sense on
> directories and not on files.

Agreed.

> - After having removed a property, no item is selected, but "Remove" is active
> and the right button is named "Edit...". Correct would be an inactive
> "Remove" button and a button named "Add..."

Ok, will do.

> Just an Idea: I would like to see this new "Edit Properties" Dialog in the
> Repo-Browser so that I can set properties there too. Is that possible?

The repobrowser works directly on the repository. Properties must be
set on a working copy. The only exception are revision properties
(like "svn:author", "svn:log", "svn:date", ...). Not sure if we should
provide a dialog to add custom rev props (you can't edit the svn:
revprops, except "svn:author" and "svn:log", but those can be edited
from the log dialog).

Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org