[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Misleading TSVN Merge Dialog

From: Simon Large <simon_at_skirridsystems.co.uk>
Date: 2006-02-23 22:53:04 CET

Ron Avriel wrote:
> Hi,
>
> Subversion merge accepts only a single range of revisions to merge into
> the working copy.
> However, the TSVN merge dialog *apparently* enables selecting multiple
> ranges for merging
> from the “show log” dialog.
> For example, it is possible to select revisions 100, 110-120 and 130 for
> merging, but this will result
> in merging all changes from revisions 99-130 including changes that the
> user may not have wanted.
>
> I think the “show log” dialog from merge should only allow selecting a
> single consecutive revision
> range.
> Note that this range must be equal to the non-filtered range otherwise
> it may be possible to
> filter (by author for example) and select a “consecutive” range while
> the range actually includes
> other filtered changes.

+1. This is misleading for the unwary user.

The log dialog already has the logic to check this in order to generate
the "revert changes from these revisions" context menu. When invoked
from the merge dialog I think it should disable the OK button unless a
contiguous range is selected. Should I file an issue for this?

Simon

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Feb 23 22:52:28 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.