Re: Possible memory leak in TSVNCache

Peter McNab wrote:

> TortoiseSVN 1.4.0, Build 5629 - 32 Bit -dev & Subversion 1.3.0,
> Win2K dual core CPU box.
>
> Explore to drive with revisioned folder.
> TSVNCache crawls.
> Memory usage climbs as expected.
> Browse back to MyComputer view.
>
> Repeat above process to the same drive as before.
> Memory usage climbs some more.
>
> Repeat above process to the same drive as before.
> Memory usage climbs some more.
>
> Select whitespace in WC.
> Press F5 .
>
> Repeat above process to the same drive as before.
> Memory usage does not climb this time.

If the memory use doesn't climb too much, then I guess that additional
memory used is due to some more directories added to the cache (due to
change notifications).

> Did some testing using a USB removable drive, marvelous thing really.
>
> Connected drive and Windows autorun feature pops up an explorer view of
> first partition.
> Selecting and moving Explorer vertical scrollbar prompts TSVNCache to
> crawl newly revealed folders.
> In TaskManager the cache memory usage climbs a bit.
> Use windows "Unplug" process and note that cache memory usage does not
> decrease as indicated by TaskManager.
>
> Repeat above process.
> Memory usage climbs some more but not a lot in % terms.
>
> Repeat above process
> Memory usage climbs some more but not a lot in % terms.
>
> Copy a WC onto the USB drive.
> Memory usage climbs some more but not a lot in % terms.
> Delete WC. (7000+ files, 1300+ Folders)
> Memory usage indicated in TaskManager does not decrease.

I've seen that too. But that's expected: Windows doesn't really free
memory which a process frees, it waits until there's no more memory
available for other processes or if windows is idle. That's because
reallocating/freeing memory takes some time (windows has to move around
memory blocks for that).

> Memory allocated did not rise above 19MB.
> There still appears to be a small, but less threatening leak still
> occurring. Sorry I cannot be more specific.

I've added a tooltip for the trayicon in revision 5641 which shows the
number of cached directories. Maybe that helps to find out where/if
there's a memory leak.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org