Re: Bug: TSVN generates absolute filenames in patch file

Ivan Zhakov wrote:
> On 1/26/06, Ivan Zhakov <chemodax@gmail.com> wrote:
>> On 1/26/06, Stefan Küng <tortoisesvn@gmail.com> wrote:
>>> On 1/26/06, Ivan Zhakov <chemodax@gmail.com> wrote:
>>>
>>>> TortoiseSVN 1.3.1 generates absolute filenames in patch file, like this:
>>>> Index: C:/Ivan/Subversion/svn-vs2003/win-tests.py
>>>> ===================================================================
>>>> --- C:/Ivan/Subversion/svn-vs2003/win-tests.py (revision 18200)
>>>> +++ C:/Ivan/Subversion/svn-vs2003/win-tests.py (working copy)
>>>> @@ -150,7 +150,7 @@
>>>> aprutil_dll_path = os.path.join(aprutil_path, objdir, 'libaprutil.dll')
>>>> apriconv_path = get(cp, 'options', '--with-apr-iconv', 'apr-iconv')
>>>> apriconv_dll_path = os.path.join(apriconv_path, objdir, 'libapriconv.dll')
>>>> - apriconv_so_path = os.path.join(apriconv_path, objdir, 'iconv')
>>>> + apriconv_so_path = os.path.abspath(os.path.join(apriconv_path,
>>>> objdir, 'iconv'))
>>>>
>>>> copy_changed_file(apr_dll_path, abs_objdir)
>>>> copy_changed_file(aprutil_dll_path, abs_objdir)
>>>>
>>>> Therefore such patch files cannot be applied on other machine.
>>> How did you create that patch exactly? What did you right-click on?
>>> What did you select in the dialog?
>> 1. Gone into C:\Ivan\Subversion\svn-vs2003 folder
>> 2. Right click on white area and select "Create Patch" in menu
>> 3. Keep all check boxes in dialog and save patch to C:\Ivan\Subversion\qq.patch
>
> Ping? Is somebody working on this problem?

Pong. Already fixed in HEAD and backported to 1.3.x branch

Simon

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org