Re: Reference to GPL licence in source files

Tobias Schäfer wrote:

> I have just implemented #213 (Files draggable from commit dialog). Before I
> commit I have a few questions.
>
> What licence header should new files have? Should I take SVNStatusListCtrl.h
> as a template? Who's name do I write there?

Yes, just use that as a template.
As for the name, you can either put your own name in there, or leave
mine there.

> Some files have a GPL at the top at the file and the following in the
> documentation comments. For example: src/TortoiseProc/CopyDlg.h
>
[snip]
>
> Shouldn't "\par license" reference the GPL?
>
> I would remove "\par requirements" completely. "win95 and winNT4" support has
> been dropped.
>
> "\version" will alway be out out of date. I would also remove that.

Those comments are leftovers from the early days of TSVN.
I think we should get rid of those (except for the top comment and the
\par requirements part).
But we can do that whenever we change such a file, no need to go over
all files right now.

> I have just noticed that the "about" dialog doesn't mention the licence. I
> remember having accepted the licence when installing TSVN but IMHO it should
> also be mentioned in the "about" dialog.

The question is how. We can't write the whole license there, just not
enough room. Maybe just "licensed under GPL"?

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org