[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Don't determine common path when creating a patch

From: Tobias Schäfer <tobiasschaefer_at_gmx.de>
Date: 2006-01-22 19:41:48 CET

On Sunday 22 January 2006 18:02, Stefan Küng wrote:
> P.S. if possible, please create the patch from the root of your working
> copy.

Well there was are bug in TSVN which prevented me from doing so :-)

When creating a patch TSVN determines the common root of all files which
are marked to be in the patch and then creates all paths relative from
there. This behaviour is certainly different to the command line client and
wrong in my opinion.

The following patch prevents TSVN from determining the common root and uses
the actual root, where "Create Patch" was called.

The line changed in my patch was introduced in r4242. Looking at the diff of
r4242 it seems that it was correct before that.

Please review this patch before applying. Stefan, I'm sure you had something
in mind when you decided to use the common directory instead of the root
directory.

btw, this patch was creating after having applied my patch. I reverted my
changes and then applied my patch again on the root folder, so it seems to
work.

[[[
"Create patch" now lists all files in the patch file relative to the directory
where "Create patch" was called. Before this change TSVN determined the
common directory and then created the patch from there. This behaviour was
confusing and different to the command line client.
]]]

Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Sun Jan 22 19:43:07 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.