Re: [BUG] Create Patch with prop-changes on parent dirs

On Tue, 17 Jan 2006 08:23:37 +0100, Stefan Küng wrote:

> It's 'fixed' as far as I *can* fix it. If you select the folder itself
> too, then even a non-recursive diff on that folder will include the
> files below it.

Aha! I see your point but...

> TSVN assumes that if you select the folder itself,
> that you want to include the property changes of that folder in the
> patchfile, so it must call 'svn diff' on that folder too. But that
> will automatically include all files below that folder too - I'd have
> to patch Subversion to have those not included.

...then I would say that the UI is very misleading - If the contained files
are implicitly included why can I then (de)select them. In this case the
user has _always_ to deselect all the files to get a valid patchfile or
deselect the parent folder (which is not very intuitive IMO).

So I would "vote" for an UI change:

If the parent folder is selected disable the checkboxes for all the files under
that folder (and selected them). Do not explicitly include that files the in
your 'svn diff'.

If the parent folder is _not_ selected then let the user decide which files
should be included (with enabled checkboxes of course).

Michael

PS: I really hate it to be nit-picking but in this use-case you'll silently
create an 'invalid' patchfile which cannot get applied again.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Jan 17 09:15:50 2006