[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: another try with SSPI, please test

From: David Hogue <davehogue_at_gmail.com>
Date: 2006-01-08 04:03:17 CET

Well, nevermind the patch. It basically undoes the initial neon patch.

On 1/7/06, David Hogue <davehogue@gmail.com> wrote:
> I'm actually making some progress on this.
>
> There is a check for (!base64Token &&
> (sspiContext->credentials.dwLower ||
> sspiContext->credentials.dwUpper)) that is there to prevent an
> infinite loop. The problem is that on the next request base64Token is
> 0 and sspiContext->credentials has left over data.
>
> I found this out while debugging if I would skip the test seven times
> the operation (log) would finally complete. It seems that clearing
> out sspiContext->credentials after a successful request would fix the
> problem. That, or checking another variable such as
> sspiContext->continueNeeded.
>
> I'm working on a small patch, but I'm not too familiar with neon so it
> might might crash or be inefficient. My first attempt at a patch is
> below, however I haven't tested it yet (still compiling).
>
> Index: ne_sspi.c
> ===================================================================
> --- ne_sspi.c (revision 5365)
> +++ ne_sspi.c (working copy)
> @@ -536,6 +536,8 @@
> sspiContext->continueNeeded = 1;
> } else {
> sspiContext->continueNeeded = 0;
> + sspiContext->credentials.dwLower = 0;
> + sspiContext->credentials.dwUpper = 0;
> }
>
> if (!(securityStatus == SEC_I_COMPLETE_AND_CONTINUE
>
>
>
>
> On 1/7/06, David Hogue <davehogue@gmail.com> wrote:
> > Nope, I ended up with 5362. Trying again with 5365 gives me the same
> > results. It comes up with the authentication window even inside the
> > domain. I completely uninstalled and reinstalled, rebooting every
> > time, just to make sure there wasn't any old files hanging around.
> >
> > I went back to rc1 and verified that SSPI is still working within the domain.
> >
> > On 1/7/06, Stefan Küng <tortoisesvn@gmail.com> wrote:
> > > David Hogue wrote:
> > > > Seems to be doing the same thing and asking for auth. I'm downloading
> > > > the latest source now and I'm going to try playing around with it to
> > > > see if I can find out anything and do a bit of debugging.
> > >
> > > Did you use the msi revision 5365?
> > >
> > > You say "asking for auth", does that mean it asks for auth even if
> > > you're part of the domain?
> > >
> > > I really hope you can help out here with debugging. Because as far as I
> > > can see it, my current patch really *should* work - but obviously it
> > > doesn't. So if you can't fix this or anyone else, I'll compile TSVN with
> > > neon and SSPI disabled.
> > >
> > > Stefan
> > >
> > > --
> > > ___
> > > oo // \\ "De Chelonian Mobile"
> > > (_,\/ \_/ \ TortoiseSVN
> > > \ \_/_\_/> The coolest Interface to (Sub)Version Control
> > > /_/ \_\ http://tortoisesvn.tigris.org
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
> > > For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
> > >
> > >
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun Jan 8 04:03:30 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.