[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: commit on multiple files is slow

From: Kalin KOZHUHAROV <kalin_at_thinrope.net>
Date: 2006-01-01 10:49:43 CET

Matthew, well, that is one of the best bug reports I have seen!!!
Thank you!
Athoer posters, PLEASE, have this as an example!

Matthew Carter wrote:
> Summary:
> Selecting and committing multiple files at once takes hundreds of times
> longer than committing each file individually.
>
> Background:
> I'm using Tortoise SVN 1.2.6 on Windows XP.
> I've got > 1GB free disk space.
> I've got 1GB memory, and this problem occurs with only 1 Windows
> Explorer window open.
> My working copy contains 9791 files and 745 directories.
> The repository and the client are on the same machine.
> This problem is 100% reproducible.
>
> The Problem:
> I have two plain text files in the top level directory of my working copy.
> Each of them contains local modifications.
> I select them both in the Windows Explorer (using LeftClick to select
> the first, then Ctrl-LeftClick to select the second).
> I right-click on one of the selected files and select "SVN Commit..."
> from the pop-up menu.
> It takes 29 minutes for the modified file list in the resulting dialog
> box to become populated so that I can click "OK" to perform the commit.
> To test whether there is some caching operation that is making it take
> long the first time, I click "Cancel" and repeat the process.
> Again, it takes 29 minutes for the modified file list to become populated.
> I click cancel again.
> This time, from the Windows Explorer, I select only one of the two
> modified files.
> I right-click on this file and select "SVN Commit..." from the pop-up menu.
> It takes less than a second for the modified file list to become
> populated so that I can click "OK" to perform the commit.
> I repeat the process to commit the other file. That takes a similarly
> short time.

Haven't looked at the code, but it smells like somebody is checking if _any_ files were modified in
case more than one is selected for commit?

Kalin.

-- 
|[ ~~~~~~~~~~~~~~~~~~~~~~ ]|
+-> http://ThinRope.net/ <-+
|[ ______________________ ]|
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun Jan 1 10:50:29 2006

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.