[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Overlay drawn on wrong file after change/folder - Nightly 5225

From: Stefan Kng <tortoisesvn_at_gmail.com>
Date: 2005-12-27 09:26:18 CET

Arne Moor wrote:

> instead of changing the overlay on a changed file, the icon was draw
> over the .svn folder. The folder was freshly checked out, than one
> file was changed and saved, the icon was drawn wrong, refreshed
> explorer via F5, the icon was drawn for the right file. Reverted
> multiple times and retried, always the same behavior.
>
> See the attached screen shot.

This is a 'bug' in the shell (explorer) itself. TSVN always tells the
shell the correct overlay (and it *never* draws an overlay for the .svn
folder). The problem here is a race condition:
* shell asks for overlay
* TSVN returns the overlay index
* before the shell can draw the overlay, an update notification is sent
   (either by the TSVN cache or another app)
* the update notification forces the shell to reload the contents of
   the shown folder
* the overlays are drawn in the 'old' order, even if the reload changed
   the file order shown.

We could reduce those wrong overlays by not sending shell notifications
every time we detect a status change. But then people will complain that
the overlays don't update after a commit/update/...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Dec 27 09:27:10 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.