Re: Bugtraq bugs

Tim Armes wrote:

> Having recently discovered that that bugtraq spec has been changed (and
> probably not all that recently) I'm going to need to update WebSVN's
> implementation. However, I've discovered some bugs in the TortoiseSVN
> implementation and specification.
>
> 1) If you set bugtraq:number to false, then you can't enter an issue ID at
> all with TSVN, neither a numeric nor a non-numeric value!

Not with HEAD.
This can only happen if you have also a bugtraq:logregex set, in which
case the regex is used to validate the issue ID.

> 2) The spec is very clear on the format of the message. It is defined as:
> logmessage + "\n" + resultstring + "\n"
>
> However, the implementation doesn't follow this at all. Your implementation
> is the following:
>
> If bugtraq:append = false Then
> Don't include first \n
> Log Message
> If no log message Then Don't include second \n either!
> Else
> Log message
> If no log message Then Don't include first \n
> Don't include second \n at all!
> Endif
>
> Which is to say, the \n's should be removed from the spec.

Corrected the specs in revision 5231.

> 3) Finally, the role of bugtraq:logregex is unclear. If that's set then
> shouldthat the only thing used to search for issue numbers when displaying a
> log or do you ALSO search for issues based on the bugtraq:message and
> bugtraq:append strings?

Also clarified this in revision 5231.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org