[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TortoiseSVN 1.3 Upgrade Problems

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2005-12-16 19:21:12 CET

Nathan Kidd wrote:
> I found some very annoying problems when upgrading TortoiseSVN from
> 1.2.6 or from one 1.3 nightly to the next. Do others have problems like
> these or is it maybe just something wrong with my box?
> Using Windows 2003 SP1. 1.3 nightly at, e.g. r5165
> 1.2.6 -> 1.3:
> - Without uninstalling previous 1.2.6, install a 1.3 nightly.
> - Install proceeds normally, but doesn't ask for reboot or show
> changelog on completion. Context menus are gone.

Next time this happens, read the last installer dialog *exactly*! It
will tell you that the installation failed (that's why the "show
changelog" checkbox isn't there - it's not the normal 'installation
succeeded' dialog but the 'installation failed' dialog).

> - Reboot, menus still gone.
> - Go to Add/Remove Programs and there are *two* TortoiseSVN entries.
> Uninstall both, and reboot.
> - Install 1.3, reboot, still no menus.
> - Uninstall 1.3.
> - Manually go through registry killing all TSVN-related keys

That should definitely not be necessary anymore. For some time now
there's a custom action in the installer which cleans all registry
entries before installing a new version of TSVN.

> 1.3 -> 1.3
> - Without uninstalling the previous 1.3 install a newer 1.3 nightly.
> Install proceeds normally, but doesn't ask for reboot or show changelog
> on completion. TSVN context menus are gone. After reboot context menus
> are still missing.
> - Uninstall 1.3, reboot.
> - Install 1.3 again, works.

Here again: the installation/upgrade failed (but unfortunately, the
custom action cleaning up all registry entries was run, so TSVN isn't
registered with the shell anymore).

> Questions/Thoughts/Discussion:
> 1. Do we support 'upgrade' installs without uninstall first? This used
> to work in 1.1x -> 1.2.3 (IIRC). Around 1.2.4 your overlay icons would
> disappear if you didn't uninstall first.

It should work with the most recent nightlies. I've changed the custom
action closing the running cache process to wait a little longer, so the
upgrade shouldn't fail anymore if the cache needs some time to quit

> 2. If "no" to 1. then is it a real technical limitation, or a matter of
> the installer isn't doing the right thing?
> 3. If you already have TSVN installed is it truly necessary to ask for
> reboot? The installer does say "such and such application has files
> locked, please close them". I can see if the shell context menu DLL is
> updated then this won't be reloaded without a reboot or the
> CTRL+ALT+SHIFT cancel-shutdown trick. But in my experience, when users
> here upgrade it's because of a functionality problem almost always is in
> TortoiseProc or Merge so there's no need to reboot to get the functional
> fixes.

And what if some communication structure used between the cache and the
shell extension changed in between versions? Then you'd get some nasty
behaviour until you really restart the explorer. And I really don't like
the idea of keeping track from which to which version we changed
something there.

> 4. This isn't ideal, but if the installer has to be released without
> "inplace-upgrade" capability then it should at least detect the old
> version is installed and prompt for uninstall first, instead of blindly
> continuing on and ending up broken.

It does uninstall the old version first (if the upgrade works and
doesn't abort, of course).


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Dec 16 19:21:39 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.