Re: Bug in Compare Revisions?

Patrick Ryan wrote:

> I have encountered a scenario where compare revisions fails.
>
> Procedure:
> - Add a file to an existing working copy.
> - Commit.
> - Rename the file using the TortoiseSVN rename function.
> - Commit.
> - Go to Show Log and try to compare revisions for the old and new names.
>
> If you want, edit it after renaming it, but the results will be the same
> if comparison is attempted between the modified version and the version
> before the rename.
>
> Expected Result: the files are compared.
>
> Actual Result: a dialog with "Failed to fetch lock information: 404 Not
> Found (<url>)".
>
> The reason seems simple enough: the change in path and name was not
> taken into account when fetching the files for comparison.

While your report is detailed and good, your conclusion is wrong :)
It's not TSVN's fault here, but a bug in the Subversion library. I've
reported this bug a while ago, and it should be fixed for 1.3. So please
try a nightly build.

The bug is that svn_client_info() throws an error when it asks the
information from a pre 1.2 server which doesn't know locks. What it
should do is to just leave the lock information empty, because with pre
1.2 servers there simply isn't any lock info available.
And TSVN has to call svn_client_info() before doing the actual diff to
get some information about the targets to diff (i.e. file or folder,
revisions, ...).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org