[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Very long time to crawl WC.

From: Peter McNab <mcnab_p_at_melbpc.org.au>
Date: 2005-12-01 14:54:27 CET

Stefan Küng wrote:

> Peter McNab wrote:
>
>> One for you, well maybe two.
>> There is still a small leak as a WC is successively loaded and unloaded.
>> However the rampant grabbing of memory as files were deleted has
>> gone, so that's very good news too.
>
>
> What do you mean by "loaded and unloaded"? How do you unload a WC?
>
Sorry Stefan, Checked out and later deleted.

>> Second, and I cannot reproduce this behavior but on one occasion
>> (that I noticed) the crawling duplicated itself.
>> See attached.
>
>
> Looks bad! I'll try to reproduce this, but so far I wasn't successful.
>
>> Apart from that the cache is looking much more responsive and safe to
>> use without "specialist" knowledge.
>
>
> I noticed that the cache now correctly refreshes the explorer on
> commits, but the drawback is that it refreshes way too often now. You
> can maybe see it if you create a new file and try to rename it - you
> might loose the focus while editing the name. Also, sometimes the
> overlays are drawn wrong (the '.svn' folder gets the overlay!!) which
> is a bug in explorer triggered by too many change notifications.
> So I think I have to remove those notifications again - so after a
> commit you'd have to hit F5 to get the correct overlays :(
>
> Stefan
>
I have another idea for you. (moan heard from a distance, or was that a
scream?)
It would really be nice if F5 could be left as a tool of last resort.
So, how about some smarts in the cache.
It's just that F5 does not have the same functionality when a file open
or close dialog is activated in an application.

Peter's try 2
To avoid the refresh delay you mentioned earlier and to avoid multiple
refreshes then another approach might suffice.
Notification requiring a refresh part of the cache arrives.
If the notification is for the same folder as the previous refresh -and-
within a suitably short space of time then :-
chances are that this folder is being or is about to be hit with a
string of changes :-
so start or restart a timer and delay further refreshes until the timer
expires. (300ms?)
else refresh immediately.
Record the last refreshed folder (which may contain further folders) and
the current time for later use.

Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Dec 1 14:55:03 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.