There really is only one case: no files have been selected when clicking
the OK button on the commit dialog. Whether a popup reminder or some
other visual reminder is used doesn't matter. Having the OK button
disabled would be a perfect solution, in my mind. Heck, that even brings
another idea to the table: disable the OK button until a log message has
been entered. I hate when people don't add comments. If it's necessary
to support that, you could have a checkbox that says, "No comment," or
something like that. I'd lean more towards forcing them to type
something, tho. Again, this is just my opinion. I don't know how others
feel about it.
Michael
-----Original Message-----
From: Stuart Celarier [mailto:SCelarier@corillian.com]
Sent: Tuesday, November 22, 2005 9:00 AM
To: dev@tortoisesvn.tigris.org
Subject: RE: File-less Commits
Let me challenge the use case here. How would you distinguish these two
cases? In both cases there are unversioned files which the user intends
to add. In the first case there are no other changes to versioned
resources (files, folders, properties). In the second case there are
changes to versioned resources. Is it reasonable to add behavior to
TortoiseSVN to cover the first case but not the second? That seems
arbitrary to me, so maybe I am missing something.
And, please, no more modal popups. In fact, I'd like to see far fewer of
them. Too often they are a crutch for poorly designed user interface:
modal dialogs slow down user interaction and add to confusion. And modal
dialogs and popups seem like the wrong touch for something that is
supposed to be a Windows shell extension.
For example, if a user makes no changes to the working copy and selects
SVN Commit, then the Enter Log Message dialog is displayed, but in
addition there is a modal dialog saying no files where changed or added
[...]. The second dialog is marked always on top, so it is in the way if
the user switches to another application, e.g., Windows Explorer to see
why the warning was generated.
Moreover, there is nothing that a user can do with the Enter Log Message
dialog: the second dialog is modal so the Enter Log Message dialog
cannot used or even be moved (e.g., to get it out of the way while
examining the source of the warning). As soon as the second dialog is
dismissed, the Enter Log Message dialog is closed. Then why show the
user the Enter Log Message dialog in the first place? That seems like
poor choice in designing the user interface.
Why not add to the functionality of the Enter Log Message dialog instead
of creating the second dialog? The information is already present: there
are 0 files selected. The user could be reminded that there is nothing
to do with additional text on the Enter Log Message dialog, and perhaps
disabling the OK button if there is nothing to do.
Cheers,
Stuart
Stuart Celarier | Corillian Corporation
-----Original Message-----
From: Flanakin Michael C Ctr HQ OSSG/OMR
[mailto:Michael.Flanakin.Ctr@Gunter.Af.Mil]
Sent: Monday, November 21, 2005 12:40 PM
To: dev@tortoisesvn.tigris.org
Subject: RE: Re: File-less Commits
Exactly. I simply forgot to check the files that I wanted to add. I hate
going thru a two step process (add, then commit) when I'm going to
commit something right away. This doesn't happen that often, so it's not
a huge deal. I just had to redo the commit. It'd just be nice to have a
popup saying, "Please select one or more files to commit" or something
like that.
Michael
-----Original Message-----
From: Simon Large [mailto:simon@skirridsystems.co.uk]
Sent: Monday, November 21, 2005 12:13 PM
To: dev@tortoisesvn.tigris.org
Subject: Re: File-less Commits
Flanakin Michael C Ctr HQ OSSG/OMR wrote:
>
> Is there any way we can disallow file-less commits? It doesn't happen
> that often, but it's just annoying when I try to commit added files
> and forget to check the files before clicking ok. The commits don't
> actually get registered with Svn, but it'd be nice to have a popup or
something.
> Not a huge deal, tho.
How do you manage that? Added files get checked by default. I assume you
mean unversioned files which you want to add but forget to.
Maybe the "There's nothing for TortoiseSVN to do here, move along
please" box would be appropriate if nothing at all is checked.
Simon
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Nov 22 16:18:17 2005