[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[TSVN] Re: TortoiseSVN looses comments when commit fails.

From: Lübbe Onken <l.onken_at_rac.de>
Date: 2005-10-06 13:59:37 CEST

Simon Large schrieb:
> Lübbe Onken wrote:
>> Wow, I missed a lot during these past days :-)
> Thought you were a bit quiet ;-) Not more holiday?

Monday: Holiday in Germany
Tuesday: Birthday party. I had a few things to prepare, so I left early.
Wednesday: Our company's "user day". I spent the whole day giving
Today: My car wouldn't start. I had to wait for a mechanic to get it up
and running again. Took me half a day to get to work...

>> Just my 0.02€:
>> 1) Rename the label "Last log messages" instead of "Log message history"
> Or just "Previous messages".
Even better

>> 2) Show the first line of the last log message in the combobox.
>> Currently the log messages are only shown when the combobox is dropped
>> down.
> I think that would remove a lot of the confusion, because at the moment
> the blank box makes it look as if there is no history there. That's why
> people aren't even opening the combo.

That's why I suggested it.

> The down side is that if you _do_ open the combo, something will always
> be pasted whether you want it or not, and then you may have to delete
> it.

The current implementation isn't 'clean' either. It looks like the combo
box' close event triggers pasting the text and not the select event. So
once you have made a selection each time you open and close the combo
box another line is pasted in the commit dialog.

I'd suggest a little different approach.
1) Get rid of the label "Previous messages"
2) Make "Previous messages" the first entry in the combo box and set the
combo box' item index to the first entry.
3) Upon selecting an entry (or closing the box if it doesn't work
otherwise), check if the first entry was selected. If not paste the text
into the edit field and select it, like you suggest below.

> If the pasted text was automatically selected, then it would be
> easier to see what you have just inserted, and easy to delete it all
> just by pressing the delete key. What do you think?

That would improve the handling even more.

>> 3) Maybe move the combobox on top of the log message edit box.
> That was also suggested yesterday, and I can't see why it is better. I
> like it where it is.

I like it there as well, but "maybe" above the edit field is better.
Someone said, that for him the combo box looks like it's connected to
the file list below it. I can understand this impression, because
Europeans[1] are used to work their way through dialogs top down from
left to right. It is not obvious why a UI interface element should
change something *above* it. Copying content from the combo box into an
edit field *below* it would be more plausible.

- Lübbe

[1] for lack of a better description

  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Oct 6 14:11:07 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.