Re: [TSVN] VS.NET, _svn and .svn folders

Mark Phippard wrote:

>>I guess I'm a little confused... Why check a registry key or
>
> environment
>
>>variable at all? Shouldn't TSVN be asking SVN what to use rather than
>>accessing directly?
>>
>>I'm guessing that's what the svn_wc_get_adm_dir api mentioned in the SVN
>>changelog is all about.
>
>
> The Subversion code is running from TortoiseSVN, and the Subversion code
> makes this decision based on an environment variable. Stefan probably is
> calling the Subversion code. But that code is setting the value based on
> the environment variable.

Not really. I'm simply using the same approach as the CL client. It
wouldn't be a good idea to use some other way to set the admin dir to
_svn. If we for example would use a simple registry key, then TSVN would
use the _svn dirs, but all other clients would still use the .svn dirs.
So I'm using the *same* setting (the env variable) as the command line
client. That way TSVN always uses the same dirname as the CL client.

> All Stefan is pointing out is that if you change the environment variable
> you have to reboot because otherwise that change is not visible to
> processes that are already running.

And even if we would use a registry key this would be true. The reason
is that the svn_wc_set_admin_dir_name() API in the Subversion library
isn't thread-safe and *must be called at the start of the program*. It
must not be changed later until the program is finished. And since the
shell extension is loaded when the shell starts, you still would have to
reboot or kill all shell processes for this setting to take effect.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org