[TSVN] Overlay icons wrong (Resurrection - new observations)

Awhile back we had this discussion:
http://tortoisesvn.tigris.org/servlets/ReadMsg?list=dev&msgNo=20555

I have what I hope is interesting information pertaining to that. The
test was performed using TortoiseSVN 1.2.4, Build 4479.

I think I found the cause of the incorrect overlay: binary files.
Here's how I reproduced the overlay problem:
1) Create a new repository (I used FSFS).
2) Check out the repository.
3) Add a plain text file to the repository and commit.
4) Open the text file in an editor and then navigate up in Explorer so
that you see the WC directory. Overlay should be green.
5) Edit the text file and save it. Refresh Explorer and the WC's overlay
should now be red.
6) Commit the changes by right-clicking the WC directory.
7) Refresh Explorer and the WC's overlay should now be green.

So far, all this works correctly. At this point you can optionally
experiment with adding other plain-text files. For example, I added a
second text file and then repeated the above steps and everything worked
okay. Then I got an executable file...

8) Find an executable file and add it to the WC. Commit this binary.
9) Open the text file in an editor and again, navigate up in Explorer so
that the WC directory is visible. The icon should be green. If not,
well, you are seeing the "bug" already.
10) If not red yet, edit the text file and save it. Refresh Explorer.
It's very likely at this point that the icon will remain green even
though there are modifications in the WC.
11) Navigate into the WC then navigate back up. This will now cause the
overlay to be red.
12) Commit the changes via the context menu on the WC. Refresh
Explorer. Again, the icon overlay is incorrect. It will be necessary
to restart TSVNCache, invoke Cleanup or more simply navigate into and
out of the WC to get the overlay correct.

Binary files in the repository seem consistent on why 95% of my WC's
have the correct overlay. Very few of my repositories have binary files
in them so I don't encounter the problem very much. However, the WC
that always, without fail, exhibits this problem has binary files in it
which gave me the clue. It would be nice if other's who are familiar
with the overlay problem can test the above and check to see if their
repositories have binary files in them. Hopefully this is reproducible
for others and not just me.

Note: The problem may have nothing to do with binary files. I know that
Subversion and thus TSVN uses binary diffing on all files so the actual
data shouldn't matter. However, the steps above work for me to
reproduce the overlay problem. Obviously it may lie somewhere else but
using a binary file produced the results for me.

--
- Valik
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org