[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN][PATCH]ResizableLib C++ standard and WinAPI compliance

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2005-08-21 15:07:48 CEST

Stefan Fuhrmann wrote:
> Hi dev,
>
> I probably forgot this one when posting the
> initial set of TSVN patches.
>
> [[[
> Improve ResizableLib
> * C++:
> * ResizableComboBox.cpp: declare loop variables in front
> of the loop when they are also accessed after the loop block
> * ResizableFrame.cpp: resolve evaluation ambiguity
> * WinAPI (32 / 64 bit)
> * ResizableLayout.cpp: use target-aware types where appropriate
> ]]]

Committed in revision 4229, except the change to ResizableComboBox.cpp.

> Index: ResizableComboBox.cpp
> ===================================================================
> --- ResizableComboBox.cpp (revision 4223)
> +++ ResizableComboBox.cpp (working copy)
> @@ -182,6 +182,7 @@
> availh -= h;
> }
> // to fill the remaining height, use items above
> + int i = 0;
> for (i=GetTopIndex()-1; availh>0 && i>=0; i--)
> {

Have a look a few lines above this one: there's already an 'int i = 0;'
there.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun Aug 21 15:08:11 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.