[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN][PATCH]workaround for DBTYPE declaration conflict

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2005-08-20 10:26:48 CEST

Stefan Fuhrmann wrote:
> Hi dev,
>
> I think this should also be committed since the
> error message otherwise produced in VC8.0 is
> hard to track down to its cause. Perhaps a
> "FIXME" should be added.
>
> [[[
> !!! FIXME !!!
>
> This is a workaround for the following problem
> in VC8.0 (VS.NET2005):
> the OLEDB headers declare DBTYPE as db.h
> does with completely different type semantics.
> ]]]
>
>
> ------------------------------------------------------------------------
>
> Index: TortoiseProc/stdafx.h
> ===================================================================
> --- TortoiseProc/stdafx.h (revision 4159)
> +++ TortoiseProc/stdafx.h (working copy)
> @@ -82,7 +82,13 @@
> #include "..\..\ext\apr\include\apr_version.h"
> #include "..\..\ext\apr-iconv\include\api_version.h"
> #include "..\..\ext\apr-util\include\apu_version.h"
> +#if _MSC_VER < 1400
> #include "..\..\ext\Subversion\db4-win32\include\db.h"
> +#else
> +#define DB_VERSION_MAJOR 4
> +#define DB_VERSION_MINOR 3
> +#define DB_VERSION_PATCH 28
> +#endif

With this, we'd have to adjust the version information every time we
link against a different BDB version. That negates the whole point of
including the header file in the first place.
I know you'd like to have this patch applied because it makes TSVN
compile with VS.NET2005, but there must be a better way to do this.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sat Aug 20 10:27:14 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.