Re: Fwd: [TSVN][PATCH]C++ standard compliant loop header scopes

>> --- TortoiseMerge/MainFrm.cpp (revision 4159)
>> +++ TortoiseMerge/MainFrm.cpp (working copy)
>> - for (int i=m_nSearchIndex;
>> i<m_pwndLeftView->m_arDiffLines->GetCount(); i++)
>> + int i = 0;
>> + for (i=m_nSearchIndex;
>> i<m_pwndLeftView->m_arDiffLines->GetCount(); i++)

Without more context, I can't tell for sure, but this
code probably actually used the value left in i by
the loop after the loop.

With the new rules, if i is declared as part of the for
loop, it goes out of scope when the for loop does.

So code that does something like:

for(int i = 0; i < arr.GetSize(); i++)
{
   if ( arr[i] == something )
     break;
}

if ( i == arr.GetSize() )
{
    // something wasn't found
}

// use arr[i] for something...

has to be changed as in the above exmple.

Thanks,

Joseph

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Aug 19 20:36:47 2005