Re: Fwd: [TSVN][PATCH]C++ standard compliant loop header scopes

Stefan Fuhrmann wrote:
> Index: TortoiseMerge/BaseView.cpp
> ===================================================================
> --- TortoiseMerge/BaseView.cpp (revision 4159)
> +++ TortoiseMerge/BaseView.cpp (working copy)
> @@ -1091,7 +1091,7 @@
> int nLength = nCount;
>
> int nTabCount = 0;
> - for (i=0; i<nLength; i++)
> + for (int i=0; i<nLength; i++)

Hmm... I'm just reading the patch here, which doesn't quite have
enough context, but...

'i' must be declared somewhere above the referenced lines here;
you should be able to remove that declaration. If not, more
careful analysis is need to make sure that code after this
isn't using the value of i after loop exit.

In fact, even if 'i' is needed below, it's declaration might
be able to be moved closer to it's usage...

I'm going to try to pull source code so I can at least see
diffs within their proper context and give better feedback.

Thanks,

Joseph

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Aug 19 20:30:32 2005