[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Running 64 bit prototype of TSVN 1.2.1 built with VS2005

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2005-08-19 13:54:40 CEST

Stefan Fuhrmann wrote:

> I will. First and formost I wanted to get the results of my work
> somewhere safe ;)
>
> There have been mainly four issues (some apply to TSVN as well):
> * the Windows *platform* is identified by _WIN32 not WIN32

Instead of changing the code in various places, can't we just use a
define like this:
#define WIN32 _WIN32
?

> * with VC++, sizeof(long)==sizeof(int)==4, even on a 64 bit platform
> (some pointer casts therefore caused access violations in debug mode)

But this would be against the C-standard? Isn't there maybe a switch in
the compiler settings to turn this 'compatibility mode' off?

> * MS considers C standard lib functions like strcpy() unsafe and
> has them marked as deprecated. Additional settings are required
> to get rid of that "noise".

Or, once I have VS2005 myself we could just get rid of the 'unsafe'
functions ;)

> * SVN's generator for VS projects does not yet support VC8.0 projects
> and platforms other than Win32 out of the box

Well, since VS2005 isn't out yet, they can't really test this. I think
they'll fix that soon.

> The above mentioned plus:
> * GRETA does not work on CHAR* anymore (out of the box) since string
> iterators are no longer implicitly convertible to pointers

I saw that you removed a check in GRETA which would refuse compiling if
that's not the case anymore. Is that safe to do?

> * DBTYPE in BDB\db.h conflicts with a definition deep in the oledb headers
> (trying to exclude the latter produced inconsistent vtables - yuck!)
> * loop header declarations belong to the loop's scope
> (implemented since 7.0, now forced)
>
> BTW, one sweet thing about VS2k5: parallel builds. Just works.

what are parallel builds?

>>>Moreover, I would like to create written build instruction bundled
>>>with a large sets of patches (> 100 files changed).
>>
>>No problem. Just send it here for reviewing.
>
>
> Done.

I got this mail, read your 'done' and wondered if you forgot to attach
the patches. Then I went to the website, searched the mailing list
archive and there it was! Seems GMail didn't like your mail - I haven't
received it. Anyway, I got your patch from the archive. Thanks!

>>Would you volunteer to provide a 64-bit installer for every release too?
>>Since I can't do it myself, we have to find someone who can do it.
>
>
> *tryingNotToOvercommit* O.k. as soon as there is a decently working
> 64 port, yes, I volunteer. However, we are still far from that point and the
> effort I may spend to get there is limited.

No problem. Until now, there are very few people in need of a 64-bit
version. And those who do still can use the 32-bit version of the
explorer if they really want to use TSVN.

So, I've applied your patch, compiled everything again. No compiler
errors (except one in ResText, because __in isn't defined).
But: TortoiseProc doesn't run anymore in debug mode. Seems like a GRETA
problem, but I'm not sure. Because even if I revert the changes you made
to GRETA, it still throws an exception.

So for now, I can't apply your patch because it breaks my build (well
not my build, but my ability to run TortoiseSVN).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Aug 19 13:55:14 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.