SteveKing wrote:
> Markus Schuh wrote:
>> 2.)
>> Excerpt from Includes.wxi
>>
>>> * include the xx-yy dictionary in the package? 1 for yes, 0 for no.
>>> Used to be handled by env.ENGBSPELL and ENSPELL.
>>
>>
>>
>> The functionality was changed: Now I have to manually change
>> Includes.wxi when I want to skip the dictionary.
>> Personally I'd prefer the old logic, where the batch tested against the
>> existence of the dictionaries and has set the env variables accordingly.
>> My first try to compile (without installed dictionaries) ended in a
>> TortoiseSVN-1.2.1.4081-dev-svn-1.2.1.msi with a size of about 100 kBytes.
>> First I was happy about the reduced installer size ;-)) But then I
>> realized the error messages of WiX in my build.log.
>> WiX seems to produce a MSI without any included files if one single file
>> is missing.
>> I would expect no MSI at all in this situation. May be I will ask on the
>> WiX mailling list.
I changed the functionality in an effort to centralise the configuration
of the build away from environment variables. On my system, the build
failed because I didn't have the dictionaries, but the environment
variables didn't get set. I attempted to move the variables referenced
by WiX into the Includes.wxi include file, and provide them with what I
thought were sensible defaults. The intent was that builders could set
up their build once, and then leave it as is.
I'll try to fix the environment variables setting part of MakeMsi.bat,
then, instead. It does seem more elegant, what with not requiring any
file editing for new builders...
>> 3.)
>> Two of the WiX configuration files include the BOM (byte-order-mark),
>> the others don't.
>> Doesn't seem to make any difference, but who knows?
>>
>> BOM included:
>> FeaturesFragment.wxs
>> Includes.wxi
>>
>> BOM not included:
>> StructureFragment.wxs
>> TortoiseSVN.wxs
>> UIFragment.wxs
>> VersionNumberInclude.wxi
I've no idea whether it makes a difference. I didn't do anything to set
the BOM, as far as I am aware.
Regards
Pete
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon Aug 8 15:17:29 2005