[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] [Proposal] Small changes to ShowLog dialog

From: Rainer Müller <mueller_rainer_at_gmx.de>
Date: 2005-07-17 13:40:55 CEST

Simon Large wrote:
> Simon Large wrote:
>
>> Hi Stefan,
>>
>> Following yesterday's Merge dialog discussions I have been thinking
>> about the ShowLog dialog. This is one of the central dialogs to TSVN
>> and can be called from almost anywhere. However, we don't always make
>> it clear where the dialog came from, nor whether the [OK] button will
>> simply close the dialog or do something based on which revision you
>> selected. This is a proposal to make things a bit clearer to the user.

Although you addressed Stefan, I will just comment a little bit on this
because you asked for it.

>> 1. Replace [OK] with 2 buttons:
>> a) Close/Cancel, always enabled:
>> Text is 'Close' if the dialog does not use the selected revision.
>> Text is 'Cancel' if the dialog can select something, and is a way of
>> ignoring that selection.
>> b) OK, only enabled if the dialog can select something and a rev is
>> actually selected.

That sounds very reasonable to me. It would make it more clear that you
can do with the dialog.

>> 2. Pass a title string which can be used to indicate what the dialog
>> is for, eg. when called from the merge dialog instead of saying
>> 'Log messages - C:\TortoiseSVN\src' it might say
>> 'Select revision range - C:\TortoiseSVN\src'

It would be great to have such an indication especially in case you have
more than one Show Log open.

>> There is an obvious problem with point 1, namely lack of space. I did
>> also wonder about replacing the 'Get all' and 'Next 100' buttons with
>> something like what is used on the Thunderbird toolbar. A single
>> button shows 'Next 100' and an arrow to the right of the button
>> produces a drop-down context menu offering 'Next 100 messages', 'Next
>> 100 revisions', 'Get all', 'Phone your mother', etc. ie. the most
>> common requirement is on the button face and related items are in the
>> submenu.

Maybe we could implement this:

Get all messages
Get next 100 messages
Get messages from revision range
Get messages from date range
Get messages until copy/rename

The "Get messages until copy/rename" would make us get rid of the "Stop On
Copy/Rename" checkbox.

I think we are talking about a greater redesign so I wanted to bring
these into discussion.

UI proposal:

The header of the Show Log dialog could look different depending on what
you choose on the drop down.

Here are the different states:

---------------------------------------
| Get all messages |\/|
---------------------------------------

---------------------------------------
| Get next 100 messages |\/|
---------------------------------------

---------------------------------------
| Get messages from revision range |\/| From: 100 To: 200
---------------------------------------

---------------------------------------
| Get messages from date range |\/| From: 01.07.2005 To: 16.07.2005
---------------------------------------

---------------------------------------
| Get messages until copy/rename |\/|
---------------------------------------

Maybe the From: and To: can even show the range if "Get all messages" is enabled
like now. It should automatically switch to "Get messages from date range" if
you start typing in the input boxes or you choose a date.

I hope my ideas are not too far away from possibilities. All in all it is just a
proposal for that I can't offer a patch due to my lack of C++ programming. Sorry
for that, I still hope you like it and are willing to take these into discussion.

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun Jul 17 13:41:12 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.