Re: [TSVN] Re: Changing location of stored commit messages

Valik wrote:
> At the moment, it's purely rhetorical. However, I know how much I
> despise it when applications abuse the registry by storing things that
> don't belong there. It's even worse when applications leave things
> behind. All these things contribute to a bloated registry. I'm not
> accusing TSVN of this of course, I'm just stating that in general, there
> is already a lot of crap and intentionally putting more stuff just
> compounds the issue.

The biggest performance problem with the registry is if apps leave
entries behind for deleted COM objects. TSVN doesn't do that.

> A lot of small commit messages are just as potent as a few large
> commits. Also, I believe strings stored in the registry are stored as
> Unicode, so that right there doubles the size automatically.

We only store the last ten (10) log messages. Not more.

> I forgot about the Windows 95/98 INI limits. Also, there is a

The limit per entry (not the whole ini file size) is not just for 95/98
but for all OS versions.

> XML would also add more "bloat" with the text used for its tags and
> such. It was only a suggestion, anyway. I think the most realistic
> solution and also the most simple to implement would be a custom file
> format. I think a NULL delimited double-NULL terminated file would be
> sufficient for storage. Store the files in a directory such as
> "%APPDATA%\TortoiseSVN\History\" with the file named after the UUID of
> the repository. That's very similar to what's done now with the
> registry.

Care to send a patch for this? ;)

> Keep in mind, too, that just because nobody has had problems before
> don't mean they won't. I don't think the custom-format idea is so
> radical that implementing it would cause regressions like switching to
> XML might. Also the custom-format isn't very much work. The code for
> that can be written off the top of one's head provided they don't
> already have code lying about to split a string by a delimiter.

I don't think it would be a problem to implement this. It's just a lot
of work which I don't quite see a reason for. I mean if someone would
report severe performance problems it would be another issue.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org