[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[TSVN] Re: Low priority commit-dialog feature requests

From: Matthew Mastracci <matt_at_aclaro.com>
Date: 2005-06-30 21:46:15 CEST

SteveKing wrote:

>> 1. Allow "hiding" of files in the file list. This is similar to
>> ignoring them, but only lasts for the duration of the commit and makes
>> no property changes.
>
> What would that be good for?
> Apart from that, if you hide files/folders from there without Subversion
> (the library) knowing it you could end up committing those hidden
> entries anyway!

The biggest reason is that I often have other source trees grafted into
my tree for testing purposes and don't want to clutter the global ignore
lists with stuff that only exists on my machine. I usually ignore or
delete the files within a short period of time, but it would be nice to
be able to hide it if I need to do a commit while it is there so I can
verify that I've included all of the necessary files for my commit.

TortoiseSVN could either offer a warning if hidden files are selected to
be committed, or not include them in the list of files to commit, as if
they were unchecked.

...

>> If this is too messy for most users, perhaps a "More >" submenu could
>> be added:

> If you want to do that, I suggest you use the TSVN tab in the explorer
> properties dialog to set the svn:ignore property directly.

The recursive svn:ignore doesn't work very well, because it ends up
blowing away more specific ignores lower down the tree. Having to do it
by hand is a pain as well - that's probably why the right-click menu
option was added.

>> 3. Re-scan changed files for commit. I've run into cases where I
>> find problems in my commit that require changing files that were
>> previously unmodified. If I've entered a commit message already, I'd
>> like to keep the dialog up in the background, make my additional
>> change and re-scan to pick up the new changes.
>
> Why don't you just hit F5?

Whoops - I didn't realize this was implemented. :) It doesn't change
the mouse cursor to a wait cursor until you move it, so I had always
assumed that it wasn't doing anything. Sorry!

>> 4. Show all selected files as unified diff. Some changes are easier
>> to visualize as a unified diff (IMHO, of course). I'd like to be able
>> to generate a large unified diff from all of the changes that are
>> selected, rather than just single-file unified diffs. Perhaps this
>> could be added to the context menu when you hilite multiple files in
>> the commit dialog.
>
> I think you're the only one who thinks that unified diffs are easier to
> visualize than normal diffs. So this 'feature' would be too special.

I'm not arguing that unified diffs are easier to visualize - it's just
that they are the only way to visualize a number of changes at the same
time. Is there another way to visualize a large commit besides using
the "create patch" functionality?

I find it difficult to ensure that a commit of 20-30 files with
one-liner changes (such as a minor refactoring) hasn't accidentally
included another change without using the "create patch" function.

I'm probably used to WinCVS' diff button - if you select diff on a
directory, it defaults to printing out a textual diff of all files
beneath the directory. By allowing me to select files for a unified
diff from the commit box, this makes it even more useful - I can now see
at a glance what changes were made to all of the files that are selected
and ensure that my commit isn't including bad data.

Matt.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jun 30 22:08:33 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.