[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Tortoiseproc apparently must have a shell

From: Thomas Denk <thomas.denk_at_gmail.com>
Date: 2005-06-23 11:47:53 CEST

> CREATE_SUSPENDED really might be the reason here.
> Question: do they check the return value of ResumeThread()?
Kind of... they don't really do much, but at least:
if ( ::ResumeThread(pi.hThread) == (DWORD)-1 )
    {
        // ignore it - what can we do?
        wxLogLastError(wxT("ResumeThread in wxExecute"));
    }
wxLogError, according to the documentation, shows a message box. There
is no message box, so I assume ResumeThread does not fail.

> That's now *really* strange. If you look at what TSVN does if the
> registry value is set:
>
> if (CRegDWORD(_T("Software\\TortoiseSVN\\Debug"), FALSE)==TRUE)
> AfxMessageBox(AfxGetApp()->m_lpCmdLine, MB_OK |
> MB_ICONINFORMATION);
>
> That's all! Nothing more is done if that flag is set. So why it works
> with that and not without it is a real mistery to me...

Magic... But seriously, if you want to see for yourself:
http://evidens.org/tortoise.avi.zip (1.2 megabytes). I have no
explanation for this, looks entirely impossible.
Anyway, it seems more likely that something is amiss in the 500 lines of
code that make up wxExecute than in the two lines above. So since I am
bound to use wx, I guess I'll live with the "cmd hack", after all, it
works :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jun 23 11:47:55 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.