[TSVN] FW: Flyspray task #72 - Easy application of patches

Hi Steve,

Before we start discussing via the bugtracker :-)

For completeness I added my suggestion.

> Task #72: Easy application of patches
> -----
>
> > I know Stefan has implemented it, but I dare to elaborate on what
> > I think will be the ulimate patch comfort solution.
> >
> > Current status:
> >
> > 1) Open TMerge, use "File Open" dialog to browse for patch file
> > -> takes time or
> >
> > 2) Drop Patch file somewhere inside WC, right click "apply patch"
> > fires up TMerge, uses "Browse for folder" dialog to search folder
> > -> takes time
> >
> > Now what I envision is that if I drop the patch file inside the WC
> > and select "apply patch" from the TSVN context menu, then TMerge
> > should have all the information available to apply the patch without
> > having to ask for a folder again.
> >
> > Algorithm: - First guess: Patch is applied from inside WC, so use
> > that path plus the path information contained inside the patchfile
> > to compute and suggest the correct location as it already does in
> > case 1) above - If the suggestion is declined by the user, open the
> > browse for folder dialog as it is now the case in 2)
> >
> > This would allow users to drop a patch from an e-mail anywhere
> > inside the WC, select "apply patch" and be done with it without
> > having to browse for files / folders
>
> Would it be enough if the folderbrowser would default to the working
> copy folder in that case?
> -----
>
http://tortoisesvn.berlios.de/issues/index.php?do=details&id=72&area=comment
s#tabs

Yes it would be an improvement, but I think it's unnecessary. I don't
understand why my suggestion isn't feasible?!?

A) If I fire up TMerge inside a WC, and open a patch file from anywhere,
TMerge tries to guess the correct "base path" for the patch, because it
knows it's inside a WC.

B) If I fire up Tmerge outside a WC by right-clicking on a patch file,
Tmerge has to show the folder browser, because it cannot know where to apply
the patch.

C) If I fire up TMerge inside a WC by right-clicking on a patch file, TMerge
knows it's inside a WC and it knows the name of the patch file, so it could
proceed like in A). Why show the folder browser at all?

If someone drops a patch file inside a WC, he normally wants to apply it
there. The only reason for showing the folder browser, that I see in C), is
that someone has dropped a patch file in the wrong WC and, without noticing,
selects "apply patch" there. Unless he's dropped it in a second WC of the
same project, Tmerges guess for the base folder will be wrong. That's about
the moment when the user should wake up. If people are that careless
applying patches, they deserve nothing better.

The folder browser (if shown) should default to the path of the patch file
in any case. Maybe I dropped the patch file in my WC parent folder. Then the
WC is only one click away.

Cheers
- Lübbe

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org