Re: [TSVN] blame won't work

Simon Large wrote:
[snip]
>>No, that's not TSVN's fault. Subversion returns the error message.
>>TSVN has no way of telling if the error message contains an URL or
>>not (and no, looking for URL's won't really work reliably if you
>>start thinking about it).
>
> It's not a bug, just difficult to read. What will go wrong if we
> unescape all messages? Are there any messages which contain a '%' sign
> which is not part of an escaped URL?

Well, you can for example use the '%' sign in a filename if you like.
Only Subversion knows if it's an URL or a filename, and Subversion
already does unescaping in some places. So it would be a real pain in
the ass for TSVN (that means me) to find out which messages return
unescaped paths/urls and which don't, where we have to do the unescaping
ourselves and where we shouldn't.

>>But I don't quite see the problem here: the URL is completely legal!
>>That's the real URL used by browsers too.
>
> It is legal, but not legible ;-) We allow people to enter URLs in their
> native language and then escape them before using them. So they might
> reasonably expect us to unescape them when we give them back. But if
> it's not a simple fix then we can just add that to the docs or FAQ.

Or, you could ask the Subversion devs to just unescape every URL they
return, even in error messages.
But I think they want to keep the escaped URL's in error messages,
because error messages are used to find problems, and an unescaped URL
doesn't really show where the problem is (it might be a wrong escaping!).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org