[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] blame won't work

From: Simon Large <slarge_at_slarge.plus.com>
Date: 2005-05-17 12:04:38 CEST

Norbert Unterberg wrote:
> 2005/5/17, Simon Large <slarge@slarge.plus.com>:
>
>> I'm no expert here, but in Blame.cpp, CStdioFileA::WriteString()
>> seems to be writing the string using a C-style null-terminated
>> string which maybe doesn't work properly in some systems if there is
>> an embedded \0 in the string ???
>
> I think I fixed that in revision 3062. It is not the 0 character, it
> is the unicode characters in thr blame ouput. The original code
> converted the UTF-8 to UTF-16 and then back to UTF8, thinking it was
> ANSI. So the conversion went wrong for non-ANSI (chinese/japanese)
> UTF8 characters.

Looks like you did that for the source line content but not for the
author & date fields, which still have width conversions.

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue May 17 12:05:52 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.