[TSVN] Re: svn lock returns null for username

Ben Collins-Sussman <sussman@collab.net> wrote on 05/02/2005 03:26:38 PM:

>
> On May 2, 2005, at 2:32 PM, Peter N. Lundblad wrote:
>
> >
> > It's a bug, because the client doesn't do proper input validation and
> > thereby violates its API by returning a NULL lock->owner.
> >
>
> OK, I grant you that. But if the client had been checking for NULL
> lock->owner, it would be throwing an error message to Mark, instead of
> showing a NULL value, right? Mark still would have complained, right?

Complained is probably not the right word. If the error was expressed
correctly, it could potentially have answered everything right then and
there.

See this TortoiseSVN thread for an example of the sort of side effect
problems this can cause, and why you might want to throw an error. TSVN
would have handled this much better if there had been an error.

http://svn.haxx.se/tsvn/archive-2005-05/0023.shtml

Mark

_____________________________________________________________________________
Scanned for SoftLanding Systems, Inc. by IBM Email Security Management Services powered by MessageLabs.
_____________________________________________________________________________

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon May 2 21:38:53 2005