Re: [TSVN] [Patch] Explorer Lockup resolved?

Norbert Unterberg wrote:
[snip]
> If that works, you may 'go'.

It does. Committed your patch in revision 3185.

> Regarding the TSVNCache threads closing cleanly, the way I prevere is a
> "shutdown" event, and then have the threads use WaitForMultipleObjects()
> when waiting for the pipes. But I still do not understand what that

That's a good idea! But you'd still need a way to get passed a blocking
call to ConnectNamedPipe().

> whole thing is about. When closing the application, Windows closes all
> handles. Your shutdown method wouldn't close the instance threads, would
> they?

If you end an application, then Windows also closes all threads. Problem
is if a thread is in a blocking state (e.g. waiting for an event or busy
with something else), windows just kills those threads. And killing
threads means objects aren't cleaned up properly which could lead to
crashes on shutdown. I've seen that too many times (an app crashing
because threads weren't quit cleanly) so I wanted to have a clean shutdown.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org