[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Locking UI questions

From: Simon Large <slarge_at_slarge.plus.com>
Date: 2005-04-27 18:55:08 CEST

SteveKing wrote:
>> 2. Stealing and breaking locks seems too easy.
>> The option to steal a lock is offered immediately. Should it appear
>> only after an attempt to get a lock normally has failed, ie. Dialog
>> stays open and 'Steal lock' is enabled for a second attempt? I know
>> it will waste time if you already _know_ you need to steal a lock,
>> but how often does that happen? The same could apply to 'Break
>> lock', where it only appears in the context menu after a 'Release
>> lock' has failed.
> That would clutter the UI a lot. We'd have to keep the lock dialog
> open, check for any errors that might occur during the 'get lock'
> try. In case of an error related to a lock, we'd have to do what?
> Just enable the checkbox? User's won't notice that.
> With 'break lock' appearing only if a 'release lock' has failed:
> that's not possible without a *major* hack. The context menu isn't
> linked against the full Subversion lib, and is completely independent
> of TortoiseProc doing all the work. So we'd have to find a way to
> pass that information to the shell extension part...

OK. That sounds too difficult, so I will put the warnings in the docs
(when I get started).

>> 3. The lock status and error messages seem broken in places. I did
>> Contact repository - incorrectly still reports a lock
> You check for local mods in WC1 - you still see the broken lock
> You contact the repository - you still see the lock in your wc
> But I agree - we should show there that the lock isn't there anymore
> in the repository.

Exactly. How do you clean up your WC in such a case. Is it only by a
get-lock or release-lock call?

Also, the meaning of the 'Owner' column isn't clear. In fact should that
say 'Lock owner', otherwise people might get confused with Windows
concept of file ownership?


  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Apr 27 19:34:39 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.