[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [TSVN] Create patch should ...

From: Peter Mounce <petermounce_at_iml.co.uk>
Date: 2005-04-25 18:37:49 CEST

> -----Original Message-----
> From: SteveKing [mailto:steveking@gmx.ch]
> Sent: 25 April 2005 17:28
> To: dev@tortoisesvn.tigris.org
> Subject: Re: [TSVN] Create patch should ...
> Peter Mounce wrote:
> > ... default to saving a patch as a .diff file, unless the
> user types
> > in a file extension to the filename textbox, _when_ the filetype
> > dropdown is on Patchfiles (*.diff, *.patch) ?
> >
> > If I simply type in a filename without an extension, I expect the
> > default extension to be appended - many other apps use this
> convention
> > (though some don't, eg Textpad).
> I would throw away textpad immediately if it would do that!

It doesn't do that, though, I've just noticed. Or I didn't explain myself.
See below.

> Imagine you want to edit a file "README" as you'll find
> plenty in open source projects (especially multi-platform
> ones or Linux ones). You couldn't save the file back to
> README but only to README.txt.
> The same applies to patches. And that's why I don't like the
> idea of automatically extending a filename.

Typing a name gives different behaviour than loading a file and saving it.

It only appends a file extension, _when_ you haven't got a specific type
selected to filter by in the dropdown, _and_ you haven't typed one.

If you've got "All files (*.*)" selected in the dropdown, _and_ you don't
type an extension, it doesn't append a file extension (after all, if you've
got the view on all files, you might be saving as anything).

It only selects something other than "All files (*.*)" in the dropdown view
filter if the file you're editing has an extension to begin with. If your
file has no extension, it doesn't pick one for you.
Peter Mounce
e: mailto:petermounce_at_iml.co.uk w: http://www.iml.co.uk
t: (01428) 727476 f: (01428) 727011

To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon Apr 25 18:39:56 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.