[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Number of Icon Overlays

From: SteveKing <steveking_at_gmx.ch>
Date: 2005-04-18 18:21:50 CEST

Mark Phippard wrote:
> I have been thinking more about the recent changes to drop the Added
> overlay. I wonder if it is really necessary to do this? I agree
> completely that using Modified as a substitute works, but using both works
> better. It seems to me that the only reason to dump this overlay, and
> indeed to not add new ones such as one showing that a Lock is held, is to
> be a "good citizen". We know that Windows has a limit, so we will try not
> to be wasteful in using the overlays so as not to effect other apps. I
> suppose this is admirable, but is it really necessary? For example, I do
> not use TCVS or any other products that use overlays, why should I lose
> these features which are helpful?

TortoiseCVS uses way too much overlays. And I want to keep TSVN a 'nice'
app which doesn't use all slots available so other apps still have a
chance to use one of them.

> Couldn't we do something like assign a GUID to these overlays that would
> make them very low priority, so as not to steal slots from other apps, and
> then supplement that with code that detects when they will not be used and
> switches to a substitute, such as the Modified overlay? It looks like
> this was recently done anyway, why not just take it to the next level and
> use more overlays when possible?

There's no way an overlay handler can check if other apps need overlays
too. Well, at least not without checking the corresponding registry
entries - hmmm, maybe I could do that. Have to think about that first
before I can tell you more.

One change I already made: if TSVN finds that some overlay handlers
couldn't be loaded because of too few slots, then it substitutes e.g.
the 'readonly' with 'normal' and 'deleted' with 'modified'.

> I guess I am just thinking ahead into Subclipse when I add the same
> features. In Eclipse there is no limit on overlays, so we will probably
> add overlays for these locking features, but also leave the one for Add. I
> just like that I have been able to make the Subclipse UI consistent with
> TortoiseSVN in this and other areas. It is a shame that we will have to
> diverge on this point.

TSVN can never compete with an app that doesn't have a limit on
overlays. If the shell didn't have such a limitation, I would have added
overlays for every single status available, and would even implement
overlays for combined 'status' like 'modified/locked'.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon Apr 18 18:22:33 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.