Re: [TSVN] [Patch] TMerge Unicode build

Norbert Unterberg wrote:

> I must have introduced a new bug (or uncovered an old one) with that
> patch. If you diff and modify UTF-8 files that do not have a BOM (like
> the Tortoise *.po language files), some of the special characters are
> still destroyed. I guess it is because these files are interpreted as
> ANSI and converted to UTF-16 which might fail because UTF8 files may
> contain characters that can not be mapped to UTF16 and back :-(
> I'll have a look at that later, but don't think I have time for this
> today...

That's been the case since the beginning of TMerge. It relies on text
files having the BOM so it can determine if they're UTF-x or not.

> I guess the only true way to solve these kind of problems is not to
> convert user's data at all when diffing/merging/loading/saving, only try
> to convert to correctly display the text.

I know. I've planned to rewrite TMerge one day, but never got to it
because there's always something more important to do in TSVN.
The only problem with that approach is then that you can't add the
(often requested) feature of editing files in TMerge. Of course, you
still could do it but then the user must make sure that he only edits
files which are displayed correctly.

Oh, I applied your patch in revision 3064.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org