[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] [Patch] TortoiseProc blame does not choke on unicode characters

From: SteveKing <steveking_at_gmx.ch>
Date: 2005-04-17 11:44:55 CEST

Norbert Unterberg wrote:
> TortoiseSVN-->Blame displayed badly formatted text when the file
> contains foreign UTF-8 characters. The reason for it was that
> TortoiseProc casted the svn blame output into a UTF16 CString and then
> back to 8 Bit. This conversion failed on some unicode characters, which
> made CStdioFile::WriteString fail.
> I removed this conversion by
> * adding a CStdioFileA class wich implements both WriteString(char*) and
> WriteString(WCHAR *)
> * Making the blame text line a CStringA
> I placed the CStdioFileA class directly into the blame.cpp/h files,
> breaking a "one class per module" rule. Refactor if you like....

Thanks. Applied your patch in revision 3062.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun Apr 17 11:45:10 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.