Re: [TSVN] What overlays do we NEED

Bill.Hughes@cgi-europe.com wrote:
> I think we may only need two overlays and not three. We could drop
> the 'in subversion' overlay altogether.
> 1) File has svn:needs-lock, wc has no lock -> overlay = 'no entry'
> 2) File has svn:needs-lock, wc does have lock -> overlay = 'green key'
> 3) the file doesn't have svn:needs-lock, -> 0verlay = 'green key'
> i.e. if the overlay is 'green key' the file in the wc can be updated,
> and can progress to the other status. If the overlay is 'no entry'
> the file can't be updated'

I would put this the other way.
1) File has svn:needs-lock, wc has no lock -> overlay = 'no entry'
2) File has svn:needs-lock, wc does have lock -> overlay =
'insubversion'
3) the file doesn't have svn:needs-lock, -> 0verlay = 'insubversion'

Either way it is 1 extra overlay and a possible change to an existing
one.

I don't personally like the idea of showing a key for files which are
not involved in locking, and the existing green in-subversion icon
implies that you can edit anyway. But as I said before, that's really
just tinkering with the overlay images and doesn't imply a change to the
code. If you want a green key, you can submit an icon set which has
'insubversion' replaced with 'green key'.

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org