[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] What overlays do we NEED

From: Simon Large <slarge_at_slarge.plus.com>
Date: 2005-04-14 10:58:17 CEST

Steven H @ orcon wrote:
> Do we really need all the overlays we have?
> There was debate a few months ago about what overlays to keep and can
> do away with - mabye it is time to revisit that debate?
> From the pov of trimming the four overlays we are using to two
> Deleted: I donít know about others but when I Delete a file I expect
> the file to be gone, and that happens. But when I delete a folder the
> contents of that folder disappear but the folder itself stays with a
> Deleted overlay - do we really need this overlay?
> Yes it tells you that 'this folder got deleted - commit it' - but
> (just for the sake of debate) you can get the same effect by using an
> icon which looks like a folder & deleted overlay. Of course I donít
> know if windows by default will preview a icon it does on mine.
> Adittionally a user can obtain the same information by removing the
> deleted folder, marking the deleted folders parent folder overlay as
> 'modified' - it tells you that something inside that folder changed
> and needs to be commited.

The deleting of files and (not) folders before commit is done by
Subversion, not TSVN. We can't just delete the folder, because it
contains the .svn folder which subversion is using. If you want to
change the current behaviour you have to do it in SVN.

Changing icons seems like a bad idea to me. What happens if you revert
the deletion? You have to remember somewhere that you changed that icon.
And in any case, Windows is not that good at refreshing changed icons.

But I agree that the deleted overlay is less important and could perhaps
be dropped.

> Normal: all this overlay tells you is that 'im in svn'. If the object
> (file / folder) changes it gets the modified overlay, if its
> conflicted it gets the conflicted overlay - do we _really_ need an
> overlay to tell a user that an object is 'in svn'?

I think we do. If I have forgotten to add a file/folder to subversion, I
want to see that.

> Hmmm now that I think about it more - is there any particular reason
> why NOT to make the overlay slots we use User Configerable?
> If a user doenst care about the deleted slot (like me) they can
> remove it, if they donít care about the unlocked slot it can be
> removed as well. If they want all the overlays possible (and are
> prepared to deal with possible problems) they can select them all.
> Iam not sudgesting that this be coded now but mabye as a feature for
> the next version - shall I make a feature request (do I need a login)

There is certainly some potential in that idea. When the icon slots run
out it would be good to be able to choose which ones get discarded.
Don't know how hard that would be.

Yes you do need a login to add a feature request, but let's see if there
are any other responses on the list.


  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Apr 14 10:57:25 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.