Re: [TSVN] SubWCRev update

Molle Bestefich wrote:
> Hi Simon
>
> Great work :-)

I agree!

> I was wondering, why don't we use standard CVS / SVN nomenclature for
> the attributes?
>
> Eg. replace "$WCREV$" with "$WCREV: 504 $" inside the files instead of
> requiring both source and destination files?

Simple: I never liked those keywords! You can't use them e.g in #defines
or anything else which requires a simple number.
If you replace "$WCREV$" with "7777", then you can use it in a #define.
But if you replace it with "$WCREV: 777$", then the define is not a
number but a string, which you'd have to parse and convert it into a
number first before you can use it somewhere else.

> Also applicable for the complex attributes you've just crafted:
> "$WCMIXED?TrueText:FalseText$" becomes "$WCMIXED?TrueText:FalseText:
> TrueText $.

Yeach! Ugly!

> In this regard, the colon that you've chosen between TrueText and
> FalseText is IMHO very unfortunate, and should be replaced with
> something else quickly, before it becomes common usage, so that we in
> the future can be compatible with the CVS/SVN way of doing keywords..

The colon is standard C/C++ syntax. So it's not something we just invented.
I think SubWCRev.exe should keep working the way it does now. Otherwise
we couldn't even use it anymore in TSVN for the build process without
writing scripts to parse those strings instead of clean numbers.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org